New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamic libraries under Visual Studio #78
Comments
c.c. @ksajme |
Honestly, I'm not sure what the use-case is for a CRoaring DLL... would someone really want a sparse bitmap library as a DLL? As you mention it is some extra work dealing with export etc. If it were me I'd wait until someone actually wants it, before spending time on it. But of course, YMMV! :) |
@madscientist I think it is useful to document that we do not support building a dynamic library under Visual Studio currently. |
@lemire Agreed. It's always better if these things aren't a surprise... |
I have wrapped it into a VS project: https://github.com/KingJiangNet/CRoaring.Net/tree/master/src/CRoaring |
@KingJiangNet Right. So it would not be very difficult for us to integrate this into the main code. |
Fixed in release 0.2.22. |
Currently, we can build
CRoaring
as either a shared or static library (by default as a shared library, but static withBUILD_STATIC=ON
).This works on posix systems (macOS and Linux) but for Visual Studio, we need to default on
BUILD_STATIC=ON
.For Visual Studio to support dynamic libraries, we probably need extra code (e.g.,
__declspec(dllexport)
calls?)The text was updated successfully, but these errors were encountered: