Implement roaring64 portable (de)serialization. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLieve
changed the title
Dr-Emann
reviewed
Jan 22, 2024
Dr-Emann
reviewed
Jan 23, 2024
Dr-Emann
approved these changes
Jan 23, 2024
This follows the portable spec at https://github.com/RoaringBitmap/RoaringFormatSpec#extension-for-64-bit-implementations
Also free the temporary roaring64 bitmap in case of failure.
Dr-Emann
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542.
This follows the 64-bit portable spec.
Note: I did not implement the 64-bit equivalent of
roaring_bitmap_internal_validateyet, I'm leaving that for the future as it's not strictly necessary for deserialization.