Testing amalgamation files #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, inlining differences by having all the functions in the same translation unit might be the difference? That makes some sense (and maybe we could also reproduce by using LTO then?). |
|
@Dr-Emann That is indeed the idea. I meant to write to you about it, but I had meetings. |
|
No problem. I've been finding some very interesting stuff over at RoaringBitmap/croaring-rs#128 (comment) TL;DR looking more and more like a compiler bug to me. |
…CRoaring into adding_amalgamation_tests
|
@Dr-Emann For obvious reasons, I will complete this PR. Testing the amalgamated files is a good idea. And it is cheap. |
|
I am going to merge this as I think it is uncontroversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test will build the amalgamation files and try to execute them, as part of our tests.