Using a docker container for clang-cl #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLieve
reviewed
Jan 30, 2024
Dr-Emann
reviewed
Jan 31, 2024
There was a problem hiding this comment.
I'd like to consider trying to use a local clang-format if available (and the right version)?
Something like
if clang-format-17 --version | grep -qF 'version 17.'; then
clang_format=( clang-format-17 )
elif clang-format --version | grep -qF 'version 17.'; then
clang_format=( clang-format )
else
if [ -t 0 ]; then DOCKER_ARGS=-it; fi
clang_format=( docker run --rm $DOCKER_ARGS -v "$MAINSOURCE:/app:Z" -w "/app" -u "$(id -u $USER):$(id -g $USER)" kszonek/clang-format-17 )
fi
"${clang_format[@]}" "$@"Then we can use that script as if it were clang-format itself, passing e.g. tools/clang-format.sh --style=file --verbose -i -- $ALL_CROARING_FILES in a wrapper
added 2 commits
January 31, 2024 17:24
|
@Dr-Emann Please re-review. |
Dr-Emann
reviewed
Feb 1, 2024
|
@Dr-Emann I have updated the script. |
Dr-Emann
approved these changes
Feb 2, 2024
|
Merging. |
SLieve
pushed a commit
to SLieve/CRoaring
that referenced
this pull request
Feb 3, 2024
* Using a docker container for clang-cl --------- Co-authored-by: Daniel Lemire <dlemire@lemire.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the clang-format version, use a Docker container.
See #577 (comment)