Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r64 iterator: allow moving backward with move_equalorlarger #585

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

SLieve
Copy link
Contributor

@SLieve SLieve commented Feb 3, 2024

Fixes #575. This adds the ability to move backward to both the ART iterator and the roaring64 iterator.

@SLieve SLieve marked this pull request as ready for review February 3, 2024 15:29
@SLieve SLieve requested a review from Dr-Emann February 3, 2024 15:29
This commit adds the ability to move backward to both the ART iterator and the
roaring64 iterator.
@lemire lemire merged commit 547872f into RoaringBitmap:master Feb 5, 2024
20 checks passed
@Dr-Emann
Copy link
Member

Dr-Emann commented Feb 5, 2024

@SLieve Should roaring64_iterator_move_equalorlarger work if the iterator is exhausted (it doesn't currently)?

E.g. should this work (as long as the bitmap is not empty)?:

while (roaring64_iterator_advance(it))
    ;
assert_true(roaring64_iterator_move_equalorlarger(it, 0));

@SLieve SLieve deleted the r64_ge_back branch February 6, 2024 21:23
@SLieve
Copy link
Contributor Author

SLieve commented Feb 6, 2024

Interesting question, I don't think see a reason why it shouldn't work so let's make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roaring64 iterator's move_equalorlarger can only go forward
3 participants