fix C4576 compilation error when compiling CRoaring in C++ on Windows #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 29, 2024 23:38
SalvatorePreviti
changed the title
|
@SalvatorePreviti We are getting errors with the Windows runners. I'll relaunch them in case it is a fluke. |
|
Nope. Looks like the tests are failing under Windows. |
|
Ok I will look into it thank you |
|
The problem may not be with this PR. I am investigating. |
|
The problem wasn't there 2 weeks ago, but it may not be caused by your PR: 
|
|
Oh. Right. Now I remember. |
|
It is an issue identified by @Dr-Emann We think it is a visual studio bug. |
|
I am going to merge your PR because I do not think that the failure is related. |
|
See #603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling CRoaring on Windows (tried on Windows 2019 in CI for roaring-node) causes a compilation error due to the use of (cast){initializer} used in C roaring source code.
(roaring_container_iterator_t){ ... } does not compile in Visual Studio when compiling in C++,
it fails with C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax
For reference, https://github.com/SalvatorePreviti/roaring-node/actions/runs/8102601181/job/22145475666
I think the solution is to replace (roaring_container_iterator_t){ ... } with roaring_container_iterator_t{ ... } depending if compiling for C or C++.
This PR defines a macro in containers.c that is (roaring_container_iterator_t) when compiling in C and roaring_container_iterator_t when compiling in C++
issue #599