Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reverse batched iterators #246

Open
lemire opened this issue Apr 17, 2018 · 7 comments
Open

Implement reverse batched iterators #246

lemire opened this issue Apr 17, 2018 · 7 comments

Comments

@lemire
Copy link
Member

lemire commented Apr 17, 2018

Generalize Richard's bulk iterators so we can iterate backward (in reverse)...

#243

See:

Iterating in batches over data structures can be much faster... https://lemire.me/blog/2018/04/17/iterating-in-batches-over-data-structures-can-be-much-faster/

@richardstartin
Copy link
Member

Is this and #244 blocking releasing the batch iterators?

@lemire
Copy link
Member Author

lemire commented Apr 25, 2018

Nothing is blocking a release. I'll issue a release shortly.

Hopefully today.

@lemire
Copy link
Member Author

lemire commented Apr 26, 2018

I issued the release command. I am going to go for a coffee. Or... no, for 12 or 15 coffees. Dark. No sugar.

@blacelle
Copy link
Member

@lemire do you mean the release process is still not smooth ?

@richardstartin
Copy link
Member

I get the impression the release is fairly onorous because it takes a while and @lemire is a busy guy. I was asking because it might have been nice to have batched different kinds of batch iterators into one release.

@blacelle
Copy link
Member

I guess @lemire does not need coffee just to wait commands executing by themselves. I wonder if the release process is still encountering issues requiring attention.

@lemire
Copy link
Member Author

lemire commented Apr 26, 2018

@richardstartin @blacelle

The release has been completed.

It is basically working fine and we could argue that, as long as the release process works consistently, it is not a big deal if it takes a long time.

I am lot more concerned with the time it takes running tests when people hack at the code. This impacts productivity. My productivity as the guy who types the release command is no big deal, but the productivity of folks changing the code matters a whole lot.

On a brand new iMac (desktop) a release takes over 8 minutes. The release process does not run the JMH tests or the any other tests. So it takes 8 mins just for the main tests and the release. Bringing this down to 4 mins would be great progress.

Anyhow, I drink a lot of coffee in 8 mins.

[INFO] Reactor Summary:
[INFO]
[INFO] RoaringBitmapParent 0.7.10-SNAPSHOT ................ SUCCESS [08:46 min]
[INFO] RoaringBitmap ...................................... SKIPPED
[INFO] Real Roaring Dataset ............................... SKIPPED
[INFO] JMH benchmark : RoaringBitmap ...................... SKIPPED
[INFO] Memory benchmark : RoaringBitmap 0.7.10-SNAPSHOT ... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:47 min
[INFO] Finished at: 2018-04-25T23:03:05-04:00
[INFO] ------------------------------------------------------------------------

I guess @lemire does not need coffee just to wait commands executing by themselves. I wonder if the release process is still encountering issues requiring attention.

It works much better than it once did!!!

My comments regarding coffee should not be taken as criticism of the good folks who helped make the release work better!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants