Tests and fixes for RoaringBitmap.addOffset #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
changed the title
|
The tests should all be passing now. |
|
I've ported these fixes to the buffer implementation just now (I didn't see any evidence of empty containers there either). |
|
LGTM. Merging. |
Smallhi
pushed a commit
to Smallhi/RoaringBitmap
that referenced
this pull request
Jun 14, 2021
* add assert to RoaringArray.append to reject empty input * remove slow fuzz tests which have good coverage elsewhere * fix issues with addOffset, add tests to show existence of more issues * add more failure cases where data is lost * add cardinality check to demonstrate issue more clearly * use logical rather than arithmetic shift to solve bitmap concatenation problem * more failure cases and some fixes * fix run container concatenation * demonstrate failure cases exist in buffer implementation * apply fixes to buffer implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows up some issues in
RoaringBitmap.addOffsetand fixes some low hanging fruit.RunContainer.appendwhen a run container was placed after a bitmap containerUtil.cardinalityInRangewas called.RoaringArray.appendto reject empty containers.This PR will break because it contains tests which capture bugs but I don't have time to fix them.