Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize to bytebuffer #325

Merged
merged 1 commit into from Apr 3, 2019
Merged

serialize to bytebuffer #325

merged 1 commit into from Apr 3, 2019

Conversation

richardstartin
Copy link
Member

No description provided.

@lemire
Copy link
Member

lemire commented Apr 3, 2019

This solves #322

@lemire
Copy link
Member

lemire commented Apr 3, 2019

Looks like great work to me. Thorough.

@lemire lemire merged commit 4a693d7 into RoaringBitmap:master Apr 3, 2019
@richardstartin
Copy link
Member Author

Thanks. I haven't benchmarked it but I'm sure this will soften the CPU spikes I see during serialisation of many sparse bitmaps so I am keen to pick up the next release. Please ping me when you get time to issue a release.

@lemire
Copy link
Member

lemire commented Apr 3, 2019

@richardstartin

Working on it right now. I just want to update the documentation before I issue a release.

Even if the performance was the same, the usage is now so much nicer...

@lemire
Copy link
Member

lemire commented Apr 3, 2019

I have release 0.8.0. I want with a new minor version because I think we have a much better API.

@richardstartin
Copy link
Member Author

I notice that Spark may be picking up 0.7.45 for Kryo serialisation. It may be worth their while to use ByteBuffer in preference to DataOutput.

@richardstartin
Copy link
Member Author

I can't share more details but this reduced a "CPU utilisation" spike from 50% to under 15%. It was a big efficiency gain.

@lemire
Copy link
Member

lemire commented Apr 10, 2019

@richardstartin

I fear that this long lasting inefficiency is largely my fault. I was assuming that if there were any performance differences with such functions, it would be small. I held to my assumption for too long without checking.

Smallhi pushed a commit to Smallhi/RoaringBitmap that referenced this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants