Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade junit to jupiter #396

Merged
merged 2 commits into from Apr 10, 2020
Merged

Conversation

richardstartin
Copy link
Member

upgrades to JUnit 5 ("jupiter") which has some nice features, is faster, and is very stable now

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 91.573% when pulling 7ad5f65 on richardstartin:jupiter into 80c8c7a on RoaringBitmap:master.

@lemire
Copy link
Member

lemire commented Apr 10, 2020

There is lots and lots of code, but this should be safe. I recommend merging.

Why would it be faster?

@richardstartin
Copy link
Member Author

Mostly parallelism at the method level, rather than class. Most of this is search and replace except for the parameterised tests, but note that none of the implementation classes have changed and the coverage didn't change, so the test suite must be doing the same thing.

The main benefit of merging this is being able to write and parallelise parameterised tests easily.

@richardstartin richardstartin merged commit c8e4538 into RoaringBitmap:master Apr 10, 2020
Smallhi pushed a commit to Smallhi/RoaringBitmap that referenced this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants