Avoid intermediate arrays for other container types #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielThomas
force-pushed
the
dannyt/avoid-container-copy
branch
3 times, most recently
from
df282dc
to
ae1b08b
Compare
lemire
reviewed
Apr 18, 2024
RoaringBitmap/src/main/java/org/roaringbitmap/ArrayContainer.java
Outdated
Show resolved
Hide resolved
lemire
reviewed
Apr 18, 2024
lemire
reviewed
Apr 18, 2024
lemire
reviewed
Apr 18, 2024
RoaringBitmap/src/main/java/org/roaringbitmap/RunContainer.java
Outdated
Show resolved
Hide resolved
lemire
reviewed
Apr 18, 2024
RoaringBitmap/src/main/java/org/roaringbitmap/RunContainer.java
Outdated
Show resolved
Hide resolved
lemire
reviewed
Apr 18, 2024
DanielThomas
force-pushed
the
dannyt/avoid-container-copy
branch
from
35b2b27
to
cf127ed
Compare
|
This passes all our parity tests internally too, so should be good to go now! |
|
This looks good to me, merging. |
|
Thanks @lemire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Another quick follow up to #713 to avoid
toBitmapContaineras this has shown up on hot paths for us too.Automated Checks
./gradlew testand made sure that my PR does not break any unit test../gradlew checkstyleMainor the equivalent and corrected the formatting warnings reported.