Bitmap::flip does not require &mut self
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Bitmap::flip` should only require `&self`, not `&mut self`. This should be a backwards compatable change, it only increases the set of programs accepted. Additionally, try to remove mutablilty from examples where possible, to prevent it from happening again
|
That's a great catch, thanks for your work once more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitmap::flipandBitmap::contains_rangeshould only require&self, not&mut self. This should be a backwards compatible change, it only increases the set of programs accepted.Additionally, try to remove mutability from examples where possible, to prevent this from happening again.
Also, correct the documentation of
Bitmap::minimumandBitmap::maximum