Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dependency to the retain_mut crate #224

Open
Kerollmops opened this issue Jun 28, 2022 · 1 comment
Open

Remove the dependency to the retain_mut crate #224

Kerollmops opened this issue Jun 28, 2022 · 1 comment
Labels
breaking This change will require a bump of the minor or major version. reminder

Comments

@Kerollmops
Copy link
Member

Kerollmops commented Jun 28, 2022 •
edited by reminders bot

We are depending on the retain_mut crate which has been deprecated on May 20 2022 as the standard library integrated this function since 1.61. However, we don't want to remove this dependency right now as it would force us to bump the MSRV to 1.61, we were in 1.56.1.

I would like to bump the MSRV to 1.61 but not right now, maybe in 6 months.

/remind me that must remove the retain_mut dependency in 6 months
@Kerollmops Kerollmops added the breaking This change will require a bump of the minor or major version. label Jun 28, 2022
@reminders reminders bot added the reminder label Jun 28, 2022
@reminders
Copy link

reminders bot commented Jun 28, 2022

@Kerollmops set a reminder for Dec 28th 2022

This was referenced Jun 28, 2022
Merged
Merged
bors bot added a commit that referenced this issue Jun 28, 2022
@bors @Kerollmops
Merge #225
b7c0d2d 
225: Fix the benchmarks datasets URL format r=Kerollmops a=Kerollmops

We were using an URL of the form _git://github.com/orga/repo.git_ which is wrong and GitHub broke it recently. I just changed it to make it valid by using the https://github.com/orga/repo.git format.

This PR also changes the version of `retain_mut` to _=0.1.7_ to avoid CI-breaking warnings. If you want to understand the reason why I am doing that you can read more in #224.

Co-authored-by: Kerollmops <clement@meilisearch.com>
not-jan pushed a commit to not-jan/roaring-rs that referenced this issue Aug 31, 2022
@bors @Kerollmops
Merge RoaringBitmap#225
d84b634 
225: Fix the benchmarks datasets URL format r=Kerollmops a=Kerollmops

We were using an URL of the form _git://github.com/orga/repo.git_ which is wrong and GitHub broke it recently. I just changed it to make it valid by using the https://github.com/orga/repo.git format.

This PR also changes the version of `retain_mut` to _=0.1.7_ to avoid CI-breaking warnings. If you want to understand the reason why I am doing that you can read more in RoaringBitmap#224.

Co-authored-by: Kerollmops <clement@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This change will require a bump of the minor or major version. reminder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kerollmops