Branchless array-bitmap operations #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pairwise_and benchmarks (ran on a laptop, there might be some variability) |
This commit implements a faster version of `Vec::retain` for array stores. Fixes RoaringBitmap#206.
RaduBerinde
force-pushed
the
no-branch-array-bitmap
branch
from
9bcc178
to
5d8627c
Compare
Kerollmops
approved these changes
Aug 15, 2022
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
232: Branchless array-bitmap operations r=Kerollmops a=RaduBerinde This commit implements a faster version of `Vec::retain` for array stores. Fixes RoaringBitmap#206. Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
samanpa
reviewed
Sep 6, 2022
| @@ -205,6 +205,23 @@ impl ArrayStore { | |||
| pub fn as_slice(&self) -> &[u16] { | |||
| &self.vec | |||
| } | |||
|
|
|||
| /// Retains only the elements specified by the predicate. | |||
| pub fn retain(&mut self, mut f: impl FnMut(u16) -> bool) { | |||
There was a problem hiding this comment.
Should this be unsafe? If the supplied f doesn't uphold the invariant
// SAFETY: pos is always at most i because
f(val) as usizeis at most 1.
I suspect this will lead to undefined behavior.
There was a problem hiding this comment.
Ooops didn't look at the return type in the signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a faster version of
Vec::retainfor arraystores.
Fixes #206.