-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new rangeOnfOnes implementation induces multiple test suite failures #75
Comments
This was referenced Dec 10, 2016
okay, it was no big deal. The equals() methods weren't checking for container types other than their own. fixed at 9bf6b3e (tip of glycerine/rle branch) |
mmm.... too hasty in closing; there are still some test failures with runContainer16 in place for rangeOfOnes:
|
The Not(range) algorithm was incorrect and untested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when roaringarray.go's func rangeOfOnes(start, last int) container is changed to be implemented purely with bitmaps, arrays, or rle16 containers, I see test suite failure. Here are the 3 options:
For context: this
https://github.com/RoaringBitmap/roaring/blob/master/roaringarray.go#L42
is being replaced by:
as in glycerine#1
and here are the suite fails, which are different in each case:
The text was updated successfully, but these errors were encountered: