Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster iandnot between bitmap and array containers #419

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

neena
Copy link
Contributor

@neena neena commented Apr 10, 2024

Faster and fewer allocs!

name                                            old time/op    new time/op    delta
AndNot/inPlace=true/left=bitmap/right=array-10    12.9µs ±72%     7.3µs ±26%   -43.44%  (p=0.000 n=10+10)

name                                            old alloc/op   new alloc/op   delta
AndNot/inPlace=true/left=bitmap/right=array-10    8.22kB ± 0%    0.00kB       -100.00%  (p=0.000 n=10+10)

name                                            old allocs/op  new allocs/op  delta
AndNot/inPlace=true/left=bitmap/right=array-10      2.00 ± 0%      0.00       -100.00%  (p=0.000 n=10+10)

@neena neena marked this pull request as ready for review April 10, 2024 22:13
@lemire
Copy link
Member

lemire commented Apr 10, 2024

Looks great to me. I will let it sit a bit, to give people time to review it.

@neena
Copy link
Contributor Author

neena commented Apr 16, 2024

@lemire is it okay to merge this?

@lemire
Copy link
Member

lemire commented Apr 16, 2024

Merging.

@lemire lemire merged commit 35d7182 into RoaringBitmap:master Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants