Extend Encryption API, Improve KeyGen performance #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the encryption API of this package with:
EncryptWithNonce
- Encrypts a plaintext with user provided nonce.EncryptAndNonce
- Generates a random nonce, and returns it to the user along with the ciphertext.It also makes a simple optimization to generate
p
andq
in parallel during keygen, offering a modest speed up.Primes generate concurrently:
Primes generated serially:
Finally, the benchmarks have been modified to report allocations and properly reset the timer after initializing the relevant benchmarks. Several calls to
Fatalf
have also been corrected to use a formatting directive, allowing the package and tests to used with Go1.11. Without the directive, the compilation would fail due to the stricter vet checks at compile time.