Merge pull request #962 from kukulich/builint-types

`static`, `self` and `parent` are not built-in in ReflectionNamedType adapter
Roave · Jan 9, 2022 · 0802bfb · 0802bfb
2 parents 97b524f + 9dc93cc
commit 0802bfb
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/src/Reflection/Adapter/ReflectionNamedType.php b/src/Reflection/Adapter/ReflectionNamedType.php
@@ -36,6 +36,12 @@ public function allowsNull(): bool
 
     public function isBuiltin(): bool
     {
+        $type = strtolower($this->betterReflectionType->getName());
+
+        if ($type === 'self' || $type === 'parent' || $type === 'static') {
+            return false;
+        }
+
         return $this->betterReflectionType->isBuiltin();
     }
 }
diff --git a/test/unit/Reflection/Adapter/ReflectionNamedTypeTest.php b/test/unit/Reflection/Adapter/ReflectionNamedTypeTest.php
@@ -4,11 +4,14 @@
 
 namespace Roave\BetterReflectionTest\Reflection\Adapter;
 
+use PhpParser\Node;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass as CoreReflectionClass;
 use ReflectionNamedType as CoreReflectionNamedType;
 use Roave\BetterReflection\Reflection\Adapter\ReflectionNamedType as ReflectionNamedTypeAdapter;
+use Roave\BetterReflection\Reflection\ReflectionMethod as BetterReflectionMethod;
 use Roave\BetterReflection\Reflection\ReflectionNamedType as BetterReflectionNamedType;
+use Roave\BetterReflection\Reflector\Reflector;
 
 use function array_combine;
 use function array_map;
@@ -86,4 +89,30 @@ public function testAdapterMethods(string $methodName, ?string $expectedExceptio
         $adapter = new ReflectionNamedTypeAdapter($reflectionStub, false);
         $adapter->{$methodName}(...$args);
     }
+
+    public function dataNotBuildin(): array
+    {
+        return [
+            ['self'],
+            ['sElF'],
+            ['static'],
+            ['sTaTiC'],
+            ['parent'],
+            ['PaReNt'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataNotBuildin
+     */
+    public function testIsNotBuiltin(string $type): void
+    {
+        $reflector = $this->createMock(Reflector::class);
+        $owner     = $this->createMock(BetterReflectionMethod::class);
+
+        $betterReflectionNamedType = new BetterReflectionNamedType($reflector, $owner, new Node\Name($type));
+        $reflectionTypeAdapter     = new ReflectionNamedTypeAdapter($betterReflectionNamedType, false);
+
+        self::assertFalse($reflectionTypeAdapter->isBuiltin());
+    }
 }