Tests that final modifier when using a method from a trait is allowed

Roave · Dec 2, 2023 · 9231247 · 9231247
1 parent e0f312c
commit 9231247
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/test/unit/Fixture/TraitFixtureWithFinal.php b/test/unit/Fixture/TraitFixtureWithFinal.php
@@ -0,0 +1,13 @@
+<?php
+
+trait SimpleTrait
+{
+    protected function foo() {}
+}
+
+class TraitFixtureWithFinal
+{
+    use SimpleTrait {
+        foo as final;
+    }
+}
diff --git a/test/unit/Reflection/ReflectionClassTest.php b/test/unit/Reflection/ReflectionClassTest.php
@@ -15,6 +15,7 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use Qux;
 use ReflectionClass as CoreReflectionClass;
@@ -1617,6 +1618,23 @@ public function testMethodsFromTraits(): void
         self::assertSame('TraitFixtureTraitC2', $classInfo->getMethod('d_renamed')->getDeclaringClass()->getName());
     }
 
+    #[RequiresPhp('8.3')]
+    public function testMethodsFromTraitsWithFinal(): void
+    {
+        $reflector = new DefaultReflector(new SingleFileSourceLocator(
+            __DIR__ . '/../Fixture/TraitFixtureWithFinal.php',
+            $this->astLocator,
+        ));
+
+        $classInfo = $reflector->reflectClass('TraitFixtureWithFinal');
+
+        self::assertTrue($classInfo->hasMethod('foo'));
+        self::assertTrue($classInfo->getMethod('foo')->isFinal());
+        self::assertFalse($classInfo->getMethod('foo')->isPrivate());
+        self::assertFalse($classInfo->getMethod('foo')->isProtected());
+        self::assertFalse($classInfo->getMethod('foo')->isPublic());
+    }
+
     public function testMethodsFromTraitsWithConflicts(): void
     {
         $reflector = new DefaultReflector(new SingleFileSourceLocator(