StringSourceLocator is forced to be built with a non-empty-string
#1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Jun 26, 2022
kukulich
force-pushed
the
no-no-empty-string
branch
from
e10a503
to
c60b2ad
Compare
kukulich
force-pushed
the
no-no-empty-string
branch
from
c60b2ad
to
cd0887f
Compare
kukulich
force-pushed
the
no-no-empty-string
branch
from
cd0887f
to
db0f714
Compare
Ocramius
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932
I've started with 6.0.0 cleanup.