Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add null to native union parameter type with = null default value #1075

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

ondrejmirtes
Copy link
Contributor

No description provided.

@Ocramius Ocramius added the bug label Apr 10, 2022
@Ocramius Ocramius requested a review from kukulich April 10, 2022 20:54
@Ocramius Ocramius added this to the 5.3.1 milestone Apr 10, 2022
@Ocramius
Copy link
Member

Potentially to be cherry-picked into 5.3.1

@Ocramius Ocramius self-assigned this Apr 10, 2022
@kukulich
Copy link
Collaborator

LGTM.

@Ocramius Ocramius changed the base branch from 5.4.x to 5.3.x April 11, 2022 08:34
@Ocramius
Copy link
Member

I'll cherry-pick onto 5.3.x and release a patch in a few (sitting in meetings)

@Ocramius Ocramius merged commit 3e09db6 into Roave:5.3.x Apr 11, 2022
@Ocramius Ocramius changed the title Allow null with native union parameter type and default null value Automatically add null to native union parameter type with = null default value Apr 11, 2022
@Ocramius
Copy link
Member

Thanks @ondrejmirtes - cutting a release 👍

@ondrejmirtes
Copy link
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants