Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection*::getNamespaceName() returns null when no namespace - namespace as empty string is implemented only in adapters #1219

Merged
merged 1 commit into from Sep 23, 2022
Merged

Reflection*::getNamespaceName() returns null when no namespace - namespace as empty string is implemented only in adapters #1219

merged 1 commit into from Sep 23, 2022

Conversation

kukulich
Copy link
Collaborator

I think the compatibility can be only in adapters.

@kukulich kukulich added this to the 6.0.0 milestone Sep 22, 2022
@kukulich kukulich marked this pull request as ready for review September 22, 2022 19:50
@Ocramius Ocramius self-assigned this Sep 22, 2022
@kukulich
Reflection*::getNamespaceName() returns null when no namespace - name…
521782d 
…space as empty string is implemented only in adapters
@Ocramius
Copy link
Member

Can't add more BC breaks to the milestone - wow Github, really? :D

@kukulich
Copy link
Collaborator Author

Mutation tests are green 🍾

Ocramius
Ocramius approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks! 🎉

@Ocramius Ocramius merged commit 7bc326b into Roave:6.0.x Sep 23, 2022
@kukulich kukulich deleted the namespace branch September 30, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
BC break enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius