-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill startLine & endLine mutants #1407
Conversation
@kukulich it looks like it doesn't improve mutations. I guess phpdoc-types are not useful for that (and only native types are taken into account?) |
Phpdoc types are considered: need to likely checked in more depth 🤔 Thanks for trying though! |
I think this can work:
No The current solution probably does not work because |
Thank you. I will give your idea a try tomorrow (Btw: the php-parser PR was merged) |
the psalm error is a bug, reported in vimeo/psalm#10826 |
It looks it's very complicated to kill one mutant 😄 |
hehe - agree, its a lot of change. but I feel the code is easier to read after the PR. |
I agree :) |
@Ocramius mutants will be killed on the next php-parser release. I think its good to go. |
<code><![CDATA[traverse]]></code> | ||
</ImpureMethodCall> | ||
<PropertyTypeCoercion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these baselined errors are related to #1407 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 4164 mutations were generated:
+ 4158 mutations were generated:
- 3333 mutants were killed
+ 3329 mutants were killed
0 mutants were configured to be ignored
14 mutants were not covered by tests
- 10 covered mutants were not detected
+ 8 covered mutants were not detected
6 errors were encountered
0 syntax errors were encountered
14 time outs were encountered
787 mutants required more time than configured
Also here, seems like a very good improvement with code reduction!
Thanks @staabm! |
Btw: notice the reduction in mutations: that really says a lot whenever we refactor :) |
lets see how nikic/PHP-Parser#985 affects mutations
refs #1382