Account for case insensitivity #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this pull request could not be found. |
|
Stop looking at your phone James |
|
Yes sorry, I won't be able to take a look before another 1-2 weeks :/ |
|
Tests added. The CI is failure is unrelated (it's failing on master as well, #421) |
Ocramius
approved these changes
May 8, 2018
|
🚢 thanks @theofidry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a bit incomplete (missing tests) but it's more for myself to not forget about it :)
The issue is that PHP is case insensitive for namespaces, classes and methods. However BetterReflection does not account for that as a result if you have:
Instead of:
BetterReflection is going to fail.