Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build failure caused by incorrectly formatted inline IDE hints #424

Merged
merged 1 commit into from May 23, 2018
Merged

Fixed build failure caused by incorrectly formatted inline IDE hints #424

merged 1 commit into from May 23, 2018

Conversation

kukulich
Copy link
Collaborator

Caused by Slevomat CS 4.6.0.

@Ocramius Ocramius self-assigned this May 23, 2018
@Ocramius Ocramius added this to the 3.0.0 milestone May 23, 2018
Ocramius
Ocramius approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

By the way, I think we should lock dependencies for the CS builds, as slevomat changing failures in a minor release is indeed a BC break for downstream (this patch being the most evident example)

@Ocramius Ocramius merged commit 30ef0f0 into Roave:master May 23, 2018
@kukulich kukulich mentioned this pull request May 23, 2018
Closed
@kukulich kukulich deleted the build branch May 23, 2018 06:31
@Ocramius Ocramius changed the title Fixed build Fixed build failure caused by incorrectly formatted inline IDE hints May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius