Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor is dead, long live Travis #464

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Conversation

kukulich
Copy link
Collaborator

No description provided.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure gold 👍

@Ocramius
Copy link
Member

Interesting: build failing (probably) because GIT is checking out everything with the wrong CRLF flags

@kukulich
Copy link
Collaborator Author

kukulich commented Apr 22, 2019

@Ocramius It should be fixed by 5b56d96#diff-fc723d30b02a4cca7a534518111c1a66R1

It works in my other repository. However it looks it does not work in PR :( The change in .gitattributes has to be in master first probably.

@Ocramius
Copy link
Member

Ok, let's try this then. If needed, I'll revert.

@Ocramius Ocramius merged commit 6f98455 into Roave:master Apr 22, 2019
@Ocramius Ocramius self-assigned this Apr 22, 2019
@Ocramius Ocramius added this to the 3.4.0 milestone Apr 22, 2019
@Ocramius
Copy link
Member

Looking good in master 👍

@kukulich kukulich deleted the travis branch April 23, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants