Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct PHPUnit MockObject class names as per PHPUnit 8+ #466

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Correct PHPUnit MockObject class names as per PHPUnit 8+ #466

merged 1 commit into from
Apr 24, 2019

Conversation

kukulich
Copy link
Collaborator

Broken since b9a4c13

@Ocramius Ocramius changed the title Fixed PHPUnit MockObject class names Correct PHPUnit MockObject class names as per PHPUnit 8+ Apr 24, 2019
@Ocramius Ocramius self-assigned this Apr 24, 2019
@Ocramius Ocramius added the bug label Apr 24, 2019
@Ocramius Ocramius added this to the 3.5.0 milestone Apr 24, 2019
@Ocramius
Copy link
Member

I wonder if we can add some minimal type-checking in the test suite?

@kukulich
Copy link
Collaborator Author

I've tried to enable psalm and phpstan for unit tests but both report too much errors currently (psalm 384 , phpstan 484)

@Ocramius
Copy link
Member

Aye, I just went through it in Roave/BackwardCompatibilityCheck#122, and it requires lots of work. Merging as-is here 👍

@Ocramius Ocramius merged commit 624be9a into Roave:master Apr 24, 2019
@kukulich kukulich deleted the phpunit branch April 24, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius