Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest jetbrains/phpstorm-stubs #490

Conversation

WyriHaximus
Copy link
Contributor

Jetbrains recently released PHPStorm 2019.2 and thus their stubs, this PR adds support for that latest stubs version

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2019

Duplicate of #488 - @kukulich was already looking at the test failures related to this

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2019

BTW, if you got time/willpower, feel free to send in patches fixing the new discrepancies :D

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2019

Closing as duplicate here.

@Ocramius Ocramius closed this Aug 1, 2019
@Ocramius Ocramius self-assigned this Aug 1, 2019
@WyriHaximus WyriHaximus deleted the jetbrains-phpstorm-stubs-2019.2 branch August 2, 2019 05:56
@WyriHaximus
Copy link
Contributor Author

Doh hadn't noticed the dependabot PR when I started on this yesterday morning 😂 . Will look into them 👍

@kukulich
Copy link
Collaborator

kukulich commented Aug 2, 2019

@WyriHaximus i’m working on it already :)

@WyriHaximus
Copy link
Contributor Author

@kukulich Yeah looked into it, and then discovered the amount of work to be done :P. I'll focus on something else instead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants