Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow phpdocumentor/type-resolver version ^1.0.0 #498

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Allow phpdocumentor/type-resolver version ^1.0.0 #498

merged 2 commits into from
Oct 3, 2019

Conversation

paul-thebaud
Copy link
Contributor

This PR updates composer.json to allow usage of phpdocumentor/type-resolver with version ^1.0.0.
It also updates composer.lock for those new dependencies (but in my opinion, composer.lock should not be committed for a package).

composer.json Outdated Show resolved Hide resolved
@Ocramius
Copy link
Member

Ocramius commented Oct 3, 2019

CI failed on something unrelated.

@Ocramius Ocramius self-assigned this Oct 3, 2019
@Ocramius Ocramius added dependencies Pull requests that update a dependency file enhancement labels Oct 3, 2019
@Ocramius Ocramius added this to the 4.0.0 milestone Oct 3, 2019
@Ocramius Ocramius merged commit 14f329c into Roave:master Oct 3, 2019
@Ocramius
Copy link
Member

Ocramius commented Oct 3, 2019

Thanks @paul-thebaud!

@kunicmarko20
Copy link

Any chance we can get a release with this fix or should I just use master?

@Ocramius
Copy link
Member

Hmm, I think I can do a round of releases on projects I maintain this week - will see if I can get it done, since I'm on the road.

@kunicmarko20
Copy link

I am on master, no rush really. Thank you!

@fezfez
Copy link

fezfez commented Feb 17, 2020

@Ocramius : any chance to have a release for this ? Thanks in advance !

@Ocramius
Copy link
Member

@asgrim besides #538, I'd be OK with releasing the new major: WDYT?

@kukulich
Copy link
Collaborator

It may be good to solve #519 before new major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants