Run CI only once on PR from another branch of the repo #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively restricts CI on push to branch or tags only.
Ocramius
requested changes
Jan 10, 2020
| @@ -2,6 +2,8 @@ os: linux | |||
| dist: xenial | |||
| language: php | |||
|
|
|||
| if: type != push OR branch = master OR branch =~ /^v?\d+\.\d+(\.\d+)?(-\S*)?$/ | |||
There was a problem hiding this comment.
Not sure if this optimisation is worth it, considering that the repo doesn't get frequent/daily contributions
There was a problem hiding this comment.
I got annoyed by Dependabot running CI twice on every opened PR/rebase too much maybe.
And well, it's also good for the planet™
There was a problem hiding this comment.
Makes sense, but you shall be pinged if this doesn't work as expected :-P
There was a problem hiding this comment.
And I'll answer the call 😎
Ocramius
approved these changes
Jan 10, 2020
Ocramius
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively restricts CI on push to branch or tags only.