Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectionClass#getConstructor() should work event if the constructor isn't the first method in the class #523

Merged
merged 1 commit into from
Jan 11, 2020
Merged

ReflectionClass#getConstructor() should work event if the constructor isn't the first method in the class #523

merged 1 commit into from
Jan 11, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Jan 11, 2020 •
edited by Ocramius
Loading

It looks @ondrejmirtes is too lazy to send PR 😛

Fixes #512

@kukulich kukulich mentioned this pull request Jan 11, 2020
Closed
Ocramius
Ocramius approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: we may need to start adding some @psalm-var list<T> in the codebase later on, to prevent these issues with non-packed arrays

@Ocramius Ocramius modified the milestones: 4.0.0, 3.5.1 Jan 11, 2020
@Ocramius Ocramius self-assigned this Jan 11, 2020
@Ocramius Ocramius added the bug label Jan 11, 2020
@Ocramius Ocramius merged commit f74d216 into Roave:master Jan 11, 2020
@Ocramius Ocramius changed the title ReflectionClass::getConstructor() should work event if the constructor isn't the first method in the class ReflectionClass#getConstructor() should work event if the constructor isn't the first method in the class Jan 11, 2020
@kukulich kukulich deleted the constructor branch January 13, 2020 10:15
@Ocramius Ocramius modified the milestones: 3.5.1, 4.0.0 Mar 1, 2020
@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2020

Re-targeted to 4.0.0: this was merged to a development branch only.

@Ocramius Ocramius mentioned this pull request Mar 19, 2020
Closed
@Ocramius Ocramius linked an issue Mar 19, 2020 that may be closed by this pull request
ReflectionClass getConstructor fails to resolve contstructor #557
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.0.0
2 participants
@kukulich @Ocramius