Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup code coverage generation by using xdebug filter #524

Merged
merged 1 commit into from Jan 11, 2020
Merged

Speedup code coverage generation by using xdebug filter #524

merged 1 commit into from Jan 11, 2020

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Jan 11, 2020

No description provided.

@kukulich
Copy link
Collaborator

Why not use pcov?

@Lctrs
Copy link
Contributor Author

Lctrs commented Jan 11, 2020

Could be an option too. But due to difference in the coverage generation, diff could be huge. The decision is not on me.

Ocramius
Ocramius approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy and effective: pcov may help further, but let's avoid more extensions if not strictly needed

@Ocramius Ocramius added this to the 4.0.0 milestone Jan 11, 2020
@Ocramius Ocramius self-assigned this Jan 11, 2020
@Ocramius Ocramius merged commit e807c7b into Roave:master Jan 11, 2020
@Lctrs Lctrs deleted the patch-1 branch January 12, 2020 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lctrs @kukulich @Ocramius