Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Psalm coverage for decoded datas from json files #526

Merged
merged 1 commit into from Jan 12, 2020
Merged

Improve Psalm coverage for decoded datas from json files #526

merged 1 commit into from Jan 12, 2020

Conversation

orklah
Copy link
Contributor

@orklah orklah commented Jan 12, 2020

As discussed here #525 I described some types to improve Psalm coverage from 98.9751% to 99.2148%

This is not very elegant but I don't see a better way without refactoring the code just to pass smaller chunks of the whole file.

@Ocramius
Copy link
Member

Good improvement! Can you also update the baseline accordingly?

@orklah
Copy link
Contributor Author

orklah commented Jan 12, 2020

Good improvement! Can you also update the baseline accordingly?

Thanks! Nothing changes in the baseline when I launch the command. I think it's because I didn't add nor remove errors, just type coverage

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as-is then 👍

@Ocramius Ocramius self-assigned this Jan 12, 2020
@Ocramius Ocramius added this to the 4.0.0 milestone Jan 12, 2020
@Ocramius Ocramius merged commit 562e093 into Roave:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants