Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies installation #529

Merged
merged 1 commit into from Jan 13, 2020
Merged

Fix dependencies installation #529

merged 1 commit into from Jan 13, 2020

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Jan 13, 2020

I suspect that the dependencies has been updated with a higher PHP version than 7.2.0, our minimal supported PHP version.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should start bumping to ^7.4 for the package itself (it's stable now, can be one safely)

@Ocramius Ocramius added bug dependencies Pull requests that update a dependency file labels Jan 13, 2020
@Ocramius Ocramius modified the milestones: 4.0.0, 3.5.1 Jan 13, 2020
@Ocramius Ocramius merged commit 87f1657 into Roave:master Jan 13, 2020
@Ocramius Ocramius self-assigned this Jan 13, 2020
@Lctrs Lctrs deleted the fixdeps branch January 13, 2020 08:58
@kukulich
Copy link
Collaborator

Is it useful for us to bump PHP to ^7.4 ? I can do it and add types to properties but I already know that @ondrejmirtes will have to revert all my changes in his fork to support even PHP 7.1.

@Ocramius
Copy link
Member

Well, over here, development needs to proceed, and we'll need to start working on 8.x support as next feature. PHP 7.2~7.3 support will be dropped much before those go EOL: if support for older versions if needed, it will be in older minor releases

@kukulich
Copy link
Collaborator

So can we release 4.0.0 with ^7.2 and bump PHP to ^7.4 then?

@Ocramius
Copy link
Member

Seems acceptable

@ondrejmirtes
Copy link
Contributor

I've wanted to write a tool that would convert 7.4 code to 7.1 anyway :D So I can write PHPStan in phpstan-src in PHP 7.4 only, but still support PHP 7.1 in the PHAR.

@Ocramius
Copy link
Member

If you are working on that, see https://github.com/endel/galapagos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants