various improvements for psalm

[orklah]

I fixed some errors, updated baseline.

It improved type coverage a bit.

[asgrim]

LGTM, nice fixes, thank you!

[orklah]

oh. I missed the fact that node could be null in ReflectionFunctionAbstract because it can be unitialized.

I'll fix that

[orklah]

Mmh... when trying to add null to the list of types for node, Psalm highlight 18 other lines where it's not handled.

I could fix that for Psalm by adding assert($this->node !== null); on each method using it, but I'm not sure it's the best way to go... Any thoughts?

[asgrim]

@orklah perhaps a private method that asserts the node is set, and update $this->node references to point to that method?

[asgrim]

Nice! Looks good, waiting for build 👍

[orklah]

Nice! Looks good, waiting for build 👍

Please wait. I'm trying to reconcile getNode and getInitializedNode, they both do the same thing. I'm just running tests locally

[orklah]

It's done, it should pass CI.

Thanks for the advice!

[orklah]

fixed some CS issues and rebased