Provide path to PHP Storm stubs directory #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Feb 17, 2020
Ocramius
requested changes
Feb 18, 2020
test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php
Outdated
Show resolved
Hide resolved
|
Closing, please see #550 for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the
stubsDirectoryto be optionally specified during the construction ofPhpStormStubsSourceStubber, so as to avoid calls tois_dirin stream contexts whereis_diris not implemented by a stream wrapper.This resolves a use case where BR is packaged in a phar, but the stubs directory (i.e.
phar:///tmp/app.phar/vendor/jetbrains/phpstorm-stubs) cannot be located due tois_dirreturningfalsebehind the phar stream wrapper. Because the stubs directory path is known, the path can be provided to the constructor instead of having to be resolved at runtime.