Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SA #547

Merged
merged 1 commit into from Feb 19, 2020
Merged

fix SA #547

merged 1 commit into from Feb 19, 2020

Conversation

orklah
Copy link
Contributor

@orklah orklah commented Feb 19, 2020

This should solve the two errors, one on Psalm and one on PHPStan that fails on CI.

Weirdly, I didn't have the Psalm one yesterday on my machine... (and the error on PHPStan was introduced by me by error :( )

@Ocramius Ocramius added dependencies Pull requests that update a dependency file enhancement labels Feb 19, 2020
@Ocramius Ocramius added this to the 4.0.0 milestone Feb 19, 2020
@orklah
Copy link
Contributor Author

orklah commented Feb 19, 2020

Build is failing because we use phpbench ^0.16.9 but we locked symfony/console to 5.0.4 dans phpbench only support it from 0.17

@orklah orklah mentioned this pull request Feb 19, 2020
Merged
@Ocramius Ocramius merged commit 6508b54 into Roave:master Feb 19, 2020
@Ocramius Ocramius self-assigned this Feb 19, 2020
@orklah orklah deleted the static-analysis branch February 22, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orklah @Ocramius