Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vimeo/psalm from 3.10.1 to 3.11.2 #568

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 1, 2020

Bumps vimeo/psalm from 3.10.1 to 3.11.2.

Release notes

Sourced from vimeo/psalm's releases.

Prevent crash when analysing some isset conditions

Fixes vimeo/psalm#3133

Bugfixes

  • Allow templated value T as X where X&static is expected (#3127)
  • Evaluate out class constants wherever possible (#3128)
  • Only apply loop clauses where applicable (#3125)

Conditional types & faster --diff mode

Features

Conditional Return Types

Psalm now supports conditional return types.

Improved --diff mode

Psalm's --diff mode should now produce all the same issues that running without --diff does (#3024, #3032)

Additionally, it should now run much faster for small changesets.

With this change, --diff-methods is now implied when running --diff.

Improve detection of problematic array types

Previously when dealing with arrays the mixed type subsumed everything in its path. Since Psalm converts any bare PHP array types to array<array-key, mixed>, that mixed type can hide real bugs, such as in the following code: https://psalm.dev/r/a97351e870 (this corresponds to code that caused an outage on vimeo.com).

This version of Psalm introduces slightly more careful array handling, and allows unions on mixed inside arrays in certain circumstances to allow you to catch more of these sorts of errors.

Other features

  • @psalm-property-read and @psalm-property-write are now supported as prefixed versions of @property-read and @property-write - thanks @iggyvolz (#3013)
  • Psalter can now be run without using cache (via --no-cache) - thanks @orklah!
  • You can now use a @psalm-trace annotation to figure out what type Psalm infers for a given variable – thanks @m0003r (#3080, #3106)
  • Docblock inheritance for function params is now just position-dependent, not name dependent as previously (#2722)

Bugfixes

  • improve handling of templated assertions when calling array_filter (#3008)
  • fix templating of properties (#3027, #3035)
  • @return static is now enforced in places it should have been, but was not
  • variables set in conditional branches of while expressions are now more completely understood (#3034)
  • Psalter don’t suggest hard return types for functions that don’t always return (#3030)
  • Allow __invoke to be called on unions with non-objects (#3033)
  • Allow inheritance from classes that only exist in stubs (#2191)
  • Fix class constant access rules for constant defined in subclass (#3014)
  • Use a better method for determining switch case complexity, preventing crashes (#2728)
  • @LeSuisse updated the return value of zip_open
  • Improve handling of generators (#3058, #3057)
  • Prevent array_key_exists calls from changing the array type (#3061)
... (truncated)
Commits
  • d470903 Make Algebra::negateFormula a little more safe
  • a25610c Fix #3133 - prevent crash when analysing isset
  • 8533b86 Simplify template bounds message
  • e17cfd8 Fix #3125 - only apply clauses where applicable
  • 633b210 Fix test
  • 73f8f96 Expand out class constants as early as possible
  • 15df39f Fix #3127 - allow templated param to be accepted where static is expected
  • 2939455 Update MixedArgumentTypeCoercion.md (#3129)
  • 5bc9b09 Allow memoisation of ArrayAccess::offsetGet
  • 5988149 Prevent checking assertions on $this-> types, always accessible
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 1, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/vimeo/psalm-3.11.2 branch from f2ba8e4 to 87b8303 Compare May 1, 2020 11:34
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/vimeo/psalm-3.11.2 branch from 87b8303 to 137f411 Compare May 1, 2020 13:15
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 3.10.1 to 3.11.2.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](vimeo/psalm@3.10.1...3.11.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/vimeo/psalm-3.11.2 branch from 137f411 to d47ba33 Compare May 1, 2020 14:16
@psalm-shepherd
Copy link

Psalm found errors in other files

src/Reflection/Adapter/ReflectionClass.php:237:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionProperty>' does not match the declared return type 'list<ReflectionProperty>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getProperties
src/Reflection/Adapter/ReflectionClass.php:281:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionClassConstant>' does not match the declared return type 'list<ReflectionClassConstant>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getReflectionConstants
src/Reflection/Adapter/ReflectionClass.php:331:16 - The inferred type 'array<int, Roave\BetterReflection\Reflection\Adapter\ReflectionClass>' does not match the declared return type 'array<trait-string, ReflectionClass>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getTraits
src/Reflection/Adapter/ReflectionObject.php:211:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionProperty>' does not match the declared return type 'list<ReflectionProperty>' for Roave\BetterReflection\Reflection\Adapter\ReflectionObject::getProperties
src/Reflection/Adapter/ReflectionObject.php:283:16 - The inferred type 'array<int, Roave\BetterReflection\Reflection\Adapter\ReflectionClass>' does not match the declared return type 'array<trait-string, ReflectionClass>' for Roave\BetterReflection\Reflection\Adapter\ReflectionObject::getTraits
src/Reflection/Adapter/ReflectionProperty.php:84:20 - No return values are expected for Roave\BetterReflection\Reflection\Adapter\ReflectionProperty::setValue

1 similar comment
@psalm-shepherd
Copy link

Psalm found errors in other files

src/Reflection/Adapter/ReflectionClass.php:237:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionProperty>' does not match the declared return type 'list<ReflectionProperty>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getProperties
src/Reflection/Adapter/ReflectionClass.php:281:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionClassConstant>' does not match the declared return type 'list<ReflectionClassConstant>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getReflectionConstants
src/Reflection/Adapter/ReflectionClass.php:331:16 - The inferred type 'array<int, Roave\BetterReflection\Reflection\Adapter\ReflectionClass>' does not match the declared return type 'array<trait-string, ReflectionClass>' for Roave\BetterReflection\Reflection\Adapter\ReflectionClass::getTraits
src/Reflection/Adapter/ReflectionObject.php:211:16 - The inferred type 'array<string, Roave\BetterReflection\Reflection\Adapter\ReflectionProperty>' does not match the declared return type 'list<ReflectionProperty>' for Roave\BetterReflection\Reflection\Adapter\ReflectionObject::getProperties
src/Reflection/Adapter/ReflectionObject.php:283:16 - The inferred type 'array<int, Roave\BetterReflection\Reflection\Adapter\ReflectionClass>' does not match the declared return type 'array<trait-string, ReflectionClass>' for Roave\BetterReflection\Reflection\Adapter\ReflectionObject::getTraits
src/Reflection/Adapter/ReflectionProperty.php:84:20 - No return values are expected for Roave\BetterReflection\Reflection\Adapter\ReflectionProperty::setValue

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/composer/vimeo/psalm-3.11.2 branch May 7, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants