Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Allow fetching constant name from exception #570

Merged
merged 1 commit into from
May 6, 2020
Merged

Enhancement: Allow fetching constant name from exception #570

merged 1 commit into from
May 6, 2020

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented May 6, 2020 •
edited by Ocramius
Loading

This PR

  • allows fetching the constant name from an UnableToCompileNode exception

Fixes #569.

@Ocramius Ocramius self-assigned this May 6, 2020
@Ocramius Ocramius modified the milestones: 3.5.1, 4.1.0 May 6, 2020
Ocramius
Ocramius approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Ocramius
Ocramius approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessor approach is indeed good enough for our purposes 👍

@Ocramius Ocramius merged commit cf9ff24 into Roave:master May 6, 2020
@Ocramius
Copy link
Member

Ocramius commented May 6, 2020

Thanks @localheinz!

@localheinz localheinz deleted the feature/constant branch May 6, 2020 17:55
@localheinz
Copy link
Contributor Author

Thank you, @Ocramius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Add accessors to UnableToCompileNode exception
2 participants
@localheinz @Ocramius