Fixed ReflectionMethod::isAbstract() in adapter #586
Conversation
| @@ -273,7 +273,7 @@ public function isProtected() | |||
| */ | |||
| public function isAbstract() | |||
| { | |||
| return $this->betterReflectionMethod->isAbstract(); | |||
| return $this->betterReflectionMethod->isAbstract() || $this->betterReflectionMethod->getDeclaringClass()->isInterface(); | |||
There was a problem hiding this comment.
@kukulich I think this should probable be fixed in \Roave\BetterReflection\Reflection\ReflectionClass::isAbstract too, perhaps?
There was a problem hiding this comment.
It looks the current version is right: https://3v4l.org/EBjjL
There was a problem hiding this comment.
Oh, I made a mistake, I meant the BR ReflectionMethod @kukulich 🙄 sorry
There was a problem hiding this comment.
@asgrim I'm not sure. BR is "better" so it should maybe report only really abstract methods...
But there's ReflectionMethod::getModifiers() based also on isAbstract()...
You tell me how I should fix it :D
There was a problem hiding this comment.
I wasn't kidding when I said that PHPStan is an integration test suite for BetterReflection :D https://twitter.com/OndrejMirtes/status/1261621042176548865
There was a problem hiding this comment.
You tell me how I should fix it :D
Oooooooooof
Guess we'll need more tests, but if you have a bug or scenario in mind, report a new issue referencing this thread.
The test suite and code are in good shape enough to "outsource" all of this work to the twitters :-)
|
Oops, merged the wrong MR 🙄 @kukulich see comment above 😁 |
See https://3v4l.org/sdhSP