Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed methods cache in ReflectionClass #590

Merged
merged 1 commit into from May 26, 2020
Merged

Conversation

kukulich
Copy link
Collaborator

It should cache only when all methods are processed.

Credit goes to @ondrejmirtes

Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, nice catch @kukulich !

@asgrim asgrim self-assigned this May 26, 2020
@asgrim asgrim added the bug label May 26, 2020
@asgrim asgrim added this to the 4.3.0 milestone May 26, 2020
@asgrim asgrim merged commit 267c848 into Roave:master May 26, 2020
@kukulich kukulich deleted the cache branch May 27, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants