Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods are case insensitive, and should be mapped and looked up without considering casing #601

Merged
merged 1 commit into from
May 27, 2020
Merged

Methods are case insensitive, and should be mapped and looked up without considering casing #601

merged 1 commit into from
May 27, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented May 27, 2020 •
edited
Loading

Fixes #588

Ocramius
Ocramius approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ocramius Ocramius changed the title Methods are case insensitive Methods are case insensitive, and should be mapped and looked up without considering casing May 27, 2020
@Ocramius Ocramius self-assigned this May 27, 2020
@Ocramius Ocramius added the bug label May 27, 2020
@Ocramius Ocramius added this to the 4.3.0 milestone May 27, 2020
@Ocramius Ocramius merged commit 9854417 into Roave:master May 27, 2020
@Ocramius
Copy link
Member

Thanks, @kukulich! Excellent work!

@kukulich kukulich deleted the case-insensitive-methods branch May 27, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

ReflectionClass::hasMethod(), getMethod() etc should be case insensitive
2 participants
@kukulich @Ocramius