Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ReflectionClass::isInstance() adapter compatibility with native reflection #610

Merged
merged 1 commit into from
May 28, 2020
Merged

Fixed ReflectionClass::isInstance() adapter compatibility with native reflection #610

merged 1 commit into from
May 28, 2020

Conversation

kukulich
Copy link
Collaborator

@kukulich
Copy link
Collaborator Author

Reported as PHP bug: https://bugs.php.net/bug.php?id=79645

Ocramius
Ocramius approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius
Copy link
Member

This throws a TypeError in PHP 8: shouldn't we align to that behaviour, maybe? Seems more sensible to me...

@Ocramius Ocramius added the bug label May 28, 2020
@Ocramius Ocramius added this to the 4.3.0 milestone May 28, 2020
@kukulich
Copy link
Collaborator Author

This throws a TypeError in PHP 8: shouldn't we align to that behaviour, maybe? Seems more sensible to me...

I would change it in version 4.4.0 that will require PHP 7.4.1. It would be easier: bcd55b2#diff-90219491fdbdad675bcb14b0405dc888R385

@kukulich
Copy link
Collaborator Author

And probably there are more methods that should TypeError then.

@Ocramius
Copy link
Member

Let's hold off with PHP 8 compatibility then: it will come anyway 👍

@Ocramius Ocramius changed the title Fixed ReflectionClass::isInstance() adapter compatibility with native reflection Fixed ReflectionClass::isInstance() adapter compatibility with native reflection May 28, 2020
@Ocramius Ocramius merged commit 259bb1e into Roave:master May 28, 2020
@Ocramius
Copy link
Member

Thanks @kukulich!

@Ocramius Ocramius self-assigned this May 28, 2020
@kukulich kukulich deleted the instance branch May 28, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius