-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileHelper - fix normalizing paths with protocol:// on Windows #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ondrejmirtes!
|
||
$path = 'phar://C:/Users/ondrej/phpstan.phar/src/TrinaryLogic.php'; | ||
self::assertSame( | ||
'phar://C:\Users\ondrej\phpstan.phar\src\TrinaryLogic.php', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that phars still have borked file paths 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it - 'phar://C:\Users\ondrej\phpstan.phar\src\TrinaryLogic.php'
is what we want here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but effectively this is no longer a filesystem path.
Anyway, all good with this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Previously it generated path with
phar:\\...
.