Fixed some bugs reported by Infection #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Jun 1, 2020
| @@ -343,13 +343,13 @@ public function testSetType() : void | |||
| { | |||
| $classInfo = $this->reflector->reflect(Php7ParameterTypeDeclarations::class); | |||
| $methodInfo = $classInfo->getMethod('foo'); | |||
| $parameterInfo = $methodInfo->getParameter('intParam'); | |||
| $parameterInfo = $methodInfo->getParameter('forSetType'); | |||
|
|
|||
| $parameterInfo->setType('string'); | |||
There was a problem hiding this comment.
These are solved by the memoizing parser being immutable. alternatively, we need to run them in separate processes.
By using separate parameters/methods/etc we are just moving the mine to some other location, where somebody else will trip it.
There was a problem hiding this comment.
Makes sense. Added @runInSeparateProcess
kukulich
force-pushed
the
infection
branch
2 times, most recently
from
840f506
to
8eb34a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.