-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ReflectionClass::getImmediateInterfaces()
to only return immediately implemented interfaces
#649
Conversation
@@ -1493,7 +1493,7 @@ static function (ReflectionClass $interface) : string { | |||
sort($dInterfaces); | |||
|
|||
self::assertSame(['B'], $cInterfaces); | |||
self::assertSame(['A', 'B', 'C'], $dInterfaces); | |||
self::assertSame(['A', 'C'], $dInterfaces); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you @kukulich
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excellent work! \o/
@@ -1493,7 +1493,7 @@ static function (ReflectionClass $interface) : string { | |||
sort($dInterfaces); | |||
|
|||
self::assertSame(['B'], $cInterfaces); | |||
self::assertSame(['A', 'B', 'C'], $dInterfaces); | |||
self::assertSame(['A', 'C'], $dInterfaces); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 💪
ReflectionClass::getImmediateInterfaces()
to only return immediately implemented interfaces
Fixes #643