Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed ReflectionNamedType does allow null values #941

Merged
merged 1 commit into from
Jan 3, 2022
Merged

mixed ReflectionNamedType does allow null values #941

merged 1 commit into from
Jan 3, 2022

Conversation

ondrejmirtes
Copy link
Contributor

Matches PHP core behaviour: https://3v4l.org/FO5e4

@ondrejmirtes ondrejmirtes mentioned this pull request Jan 3, 2022
Closed
@Ocramius Ocramius changed the base branch from 5.1.x to 5.0.x January 3, 2022 20:42
@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2022

@ondrejmirtes could you rebase this onto 5.0.x? I'd tag a patch release afterwards 👍

@Ocramius Ocramius added this to the 5.0.1 milestone Jan 3, 2022
@Ocramius Ocramius added the bug label Jan 3, 2022
@ondrejmirtes
Copy link
Contributor Author

Rebased :) And at least one more fix is coming, once I figure out something :)

Ocramius
Ocramius approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ondrejmirtes!

src/Reflection/Adapter/ReflectionNamedType.php Show resolved Hide resolved
@Ocramius Ocramius self-assigned this Jan 3, 2022
@Ocramius Ocramius merged commit 4c4a1da into Roave:5.0.x Jan 3, 2022
@Ocramius Ocramius changed the title ReflectionNamedType with mixed allows null mixed ReflectionNamedType does allow null values Jan 3, 2022
@github-actions github-actions bot mentioned this pull request Jan 3, 2022
Merged
@ondrejmirtes ondrejmirtes deleted the mixed-allows-null branch January 4, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ondrejmirtes @Ocramius