Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to ConfluenceWriter to upload jpg/gif/png images #253

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add ability to ConfluenceWriter to upload jpg/gif/png images #253

merged 1 commit into from
Sep 22, 2022

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Sep 22, 2022

No description provided.

@asgrim asgrim added the enhancement New feature or request label Sep 22, 2022
@asgrim asgrim added this to the 1.6.0 milestone Sep 22, 2022
@asgrim asgrim marked this pull request as draft September 22, 2022 12:11
Ocramius
Ocramius approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Nice idea to use the image contents hash here 💪

@asgrim asgrim mentioned this pull request Sep 22, 2022
Open
@Ocramius Ocramius marked this pull request as ready for review September 22, 2022 12:25
@Ocramius Ocramius merged commit d3a9b66 into 1.6.x Sep 22, 2022
@Ocramius Ocramius deleted the update-confluence-writer-to-support-all-inlined-images branch September 22, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asgrim @Ocramius