Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace humbug with infection #27

Merged
merged 2 commits into from
Aug 5, 2018
Merged

Conversation

BackEndTea
Copy link
Contributor

Humbug has been deprecated in favor of infection.

Humbug has been deprecated in favor of infection.
@Ocramius
Copy link
Member

Ocramius commented Aug 5, 2018

Can you check the build failure, please?

@BackEndTea
Copy link
Contributor Author

It looks like we aren't compatible with symfony/console 3.2, and actually need 3.4.

I'll try and fix in infection

@Ocramius
Copy link
Member

Ocramius commented Aug 5, 2018

Bumping the dependency here is also fine

Infection is not compatible with symfony/console <3.4. By adding this
as a dev dependency we can still run infection.
@BackEndTea
Copy link
Contributor Author

I have bumped the dependency as a (temporary) work-around

@Ocramius Ocramius self-assigned this Aug 5, 2018
@Ocramius Ocramius added this to the 2.2.0 milestone Aug 5, 2018
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 2551f4c into Roave:master Aug 5, 2018
@BackEndTea
Copy link
Contributor Author

Thank you @Ocramius

@BackEndTea BackEndTea deleted the update/infection branch August 5, 2018 15:08
@Ocramius
Copy link
Member

Ocramius commented Aug 5, 2018

No, thank YOU for sending the update :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants