Support PHP 7.3. #30
Closed
Support PHP 7.3. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis PHP7.3 install does not have a working xdebug, but my distro (arch) does. I can succesfully run the travis script locally. |
|
That will need to change before this patch is merged then. Do you have a Travis-CI issue to cross-reference, please? |
|
I haven't found one, however the xdebug release that supports PHP 7.3 is only in beta. I wouldn't be surprised if they add it when there is an actual release. |
|
A possible temporary workaround would be to add php 7.3 to the allowed failures in travis. Looking at the test logs, you can see that the phpunit tests succeed, but that infection fails to start. That gives at least some confidence that it works. |
|
Seems like Travis have added Xdebug to PHP 7.3 now. |
Merged
|
Superceded by #31 - thanks anyway folks 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows PHP 7.3 as a valid PHP version for this package and enables it for testing in Travis. I've run the tests locally and everything still seems to work.